Support SPIR-V deferred linking option #6500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new option "SkipDownstreamLinking" will defer final downstream IR linking to the user application. This option only has an effect if there are modules that were precompiled to the target IR using precompileForTarget(). Until now, the default behavior for SPIR-V was to use deferred linking, and the default behavior for DXIL was to use immediate/internal linking in Slang. This change only affects the SPIR-V behavior such that both deferred and non-deferred linking is supported based on the new option. To support the non-deferred option, Slang will internally call into SPIRV-Tools-link to reconstitute a complete SPIR-V shader program when necessary (due to modules having been precompiled to target IR). Otherwise, if SkipDownstreamLinking is enabled, the shader returned by e.g. getTargetCode() or getEntryPointCode() may have import linkage to the SPIR-V embedded in the constituent modules. Closes shader-slang#4994
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
cheneym2
added a commit
to cheneym2/slang
that referenced
this pull request
Feb 28, 2025
Format code for PR shader-slang#6500
cheneym2
force-pushed
the
cheneym2/spvlink2
branch
from
dca0c97 to
7199102
Compare
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
cheneym2
added a commit
to cheneym2/slang
that referenced
this pull request
Feb 28, 2025
Format code for PR shader-slang#6500
cheneym2
force-pushed
the
cheneym2/spvlink2
branch
from
c9e1b25 to
1f9543a
Compare
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
cheneym2
added a commit
to cheneym2/slang
that referenced
this pull request
Mar 1, 2025
Format code for PR shader-slang#6500
csyonghe
reviewed
Mar 1, 2025
cheneym2
force-pushed
the
cheneym2/spvlink2
branch
from
d2bee20 to
d49b82f
Compare
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
Format code for PR shader-slang#6500
csyonghe
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new option "SkipDownstreamLinking" will defer final downstream IR linking to the user application. This option only has an effect if there are modules that were precompiled to the target IR using precompileForTarget().
Until now, the default behavior for SPIR-V was to use deferred linking, and the default behavior for DXIL was to use immediate/internal linking in Slang.
This change only affects the SPIR-V behavior such that both deferred and non-deferred linking is supported based on the new option.
To support the non-deferred option, Slang will internally call into SPIRV-Tools-link to reconstitute a complete SPIR-V shader program when necessary (due to modules having been precompiled to target IR). Otherwise, if SkipDownstreamLinking is enabled, the shader returned by e.g. getTargetCode() or getEntryPointCode() may have import linkage to the SPIR-V embedded in the constituent modules.
Closes #4994